Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support lsp "codeAction/resolve" #5118

Closed
sigmaSd opened this issue Dec 11, 2022 · 1 comment · Fixed by #7677
Closed

Support lsp "codeAction/resolve" #5118

sigmaSd opened this issue Dec 11, 2022 · 1 comment · Fixed by #7677
Labels
A-language-server Area: Language server client C-enhancement Category: Improvements

Comments

@sigmaSd
Copy link
Contributor

sigmaSd commented Dec 11, 2022

Summary

What' supposed to happen:

  • client -> "textDocument/codeAction" -> server
  • server -> Available Actions -> client
  • when user hits enter client -> "codeAction/resolve" -> server

The third step seems to be not made in helix

deno lsp uses this code action for refactoring (going from arrow function to normal function for example)

It seems like this resolve method is used to improve performance, so by default the codeAction edits will be set to None unless the client try to resolve it denoland/deno#9405

Platform

linux

Terminal Emulator

wezterm

Helix Version

helix 22.12

@sigmaSd sigmaSd added the C-bug Category: This is a bug label Dec 11, 2022
@sigmaSd sigmaSd changed the title Support "codeAction/resolve" Support lsp "codeAction/resolve" Dec 11, 2022
@sigmaSd
Copy link
Contributor Author

sigmaSd commented Dec 11, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-language-server Area: Language server client C-enhancement Category: Improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants