SQL highlighting fails for INSERT ... SET, INSERT ... VALUES with multiple records, and GROUP_CONCAT with SEPARATOR

[LeoniePhiline]

Summary

Example SQL:

INSERT INTO ... SET ... syntax:

INSERT INTO some_table
  field = "String does not get highlight in INSERT SET syntax";

helix 22.12: String value does not get highlight:

INSERT INTO ... (...) VALUES (...) syntax with multiple values records:

INSERT INTO some_table
  (field)
VALUES
  ("String value"),
  ("String value");

helix 22.12: Values of second record do not get highlight:

GROUP_CONCAT with SEPARATOR:

SELECT GROUP_CONCAT(uid SEPARATOR ",") 
FROM some_table 
GROUP BY some_field;

SELECT GROUP_CONCAT(uid SEPARATOR ",") 
FROM some_table 
GROUP BY some_field;

helix 22.12: Separator string appears to not be expected (only "," should be yellow):

Theme for all screenshots: monokai_pro_spectrum

Reproduction Steps

I tried this:

Typed the above SQL queries (MySQL dialect) into helix.

Alternatively, copy-paste and use :set-language sql or write to an *.sql file.

I expected this to happen:

Proper highlighting (see GitHub highlight above).

Instead, this happened:

Erratic highlighting (see helix screenshots above).

Helix log

(nothing relevant in the helix log)

Platform

openSUSE Tumbleweed

Terminal Emulator

konsole

Helix Version

22.12

[archseer]

I'd start by upgrading https://github.com/DerekStride/tree-sitter-sql to the latest revision. If that doesn't fix it it'll need to be reported upstream

[pascalkuthe]

#5071 is possibly related. Although the issue itself is very different the issue was solved by upgrading the parser. Perhaohs that helps here aswell as the current version is known to be buggy

[LeoniePhiline]

Notably, like mentioned in #5071 I also experienced terrible input delays (hangs in insert mode) while working on an SQL file of only a few kilobytes. (Containing variants of the mis-highlighted syntax extracted above.)

[LeoniePhiline]

I tested with helix latest master and updated tree-sitter-sql to latet master as well (+ grammar fetch & build).
However, this lead to no improvements.

I reported the issue upstream at DerekStride/tree-sitter-sql#67

[LeoniePhiline]

There is another weird behavior. Do you guys see this as a possible helix bug? The effect is unstable and highlighting switches between correct and incorrect just by e.g. adding white space characters or doing other non-syntax editing.

I described it in DerekStride/tree-sitter-sql#67 (comment)