Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

select_register incorrectly shows the oldest value in registers #5241

Closed
xJonathanLEI opened this issue Dec 21, 2022 · 0 comments · Fixed by #6985
Closed

select_register incorrectly shows the oldest value in registers #5241

xJonathanLEI opened this issue Dec 21, 2022 · 0 comments · Fixed by #6985
Labels
C-bug Category: This is a bug

Comments

@xJonathanLEI
Copy link
Contributor

Summary

Most commands overwrite the entire register with a Vec of size 1, so at any given point in time there's only 1 value in the register. However, some commands like search maintains history and actually pushes to the register instead. Currently, the select_register command (") incorrectly takes the oldest value for these stacked registers instead of the latest one.

Discovered this bug while working on #5112 :)

Reproduction Steps

Simply make two different searches, then press " to see the list of registers.

In the list, " would show the earlier search pattern instead of the latest one for register /.

Helix log

No response

Platform

Linux

Terminal Emulator

tmux 3.3a

Helix Version

22.12-56-g6ab85917

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug
Projects
None yet
1 participant