Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic when Edits the current line in the $EDITOR program #6734

Closed
Renkai opened this issue Apr 13, 2023 · 1 comment · Fixed by #5468
Closed

Panic when Edits the current line in the $EDITOR program #6734

Renkai opened this issue Apr 13, 2023 · 1 comment · Fixed by #5468
Labels
A-helix-term Area: Helix term improvements C-bug Category: This is a bug

Comments

@Renkai
Copy link

Renkai commented Apr 13, 2023

Summary

After I set hx as the default editor in zsh, I got panic when trying to edit the command with ctrl-x ctrl-e

Reproduction Steps

I tried this:

  1. export EDITOR='hx' in ~/.zshrc
  2. ctrl-x ctrl-e in my terminal

I expected this to happen:
Helix opened, put what I already typed in the terminal into buffer.

Instead, this happened:

➜  ~ thread 'main' panicked at 'reader source not set', /Users/brew/Library/Caches/Homebrew/cargo_cache/registry/src/github.com-1ecc6299db9ec823/crossterm-0.26.1/src/event/read.rs:38:30
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Helix log

~/.cache/helix/helix.log
2023-04-13T13:34:40.867 helix_vcs [ERROR] Error {
    context: "failed to open git repo",
    source: Discover(
        NoGitRepository {
            path: "/private/tmp",
        },
    ),
}
2023-04-13T13:34:40.867 helix_vcs [ERROR] failed to open diff base for /private/tmp/zshtIXKYX
2023-04-13T13:34:40.867 helix_vcs [ERROR] Error {
    context: "failed to open git repo",
    source: Discover(
        NoGitRepository {
            path: "/private/tmp",
        },
    ),
}
2023-04-13T13:34:40.867 helix_vcs [ERROR] failed to obtain current head name for /private/tmp/zshtIXKYX```

</details>


### Platform

macOS

### Terminal Emulator

wezterm

### Helix Version

helix 23.03
@Renkai Renkai added the C-bug Category: This is a bug label Apr 13, 2023
@archseer
Copy link
Member

Probably the tty issue on macOS: #5468

@kirawi kirawi added the A-helix-term Area: Helix term improvements label Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements C-bug Category: This is a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants