Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helix uses Windows settings under MSYS2 #7239

Closed
go2null opened this issue Jun 5, 2023 · 2 comments
Closed

Helix uses Windows settings under MSYS2 #7239

go2null opened this issue Jun 5, 2023 · 2 comments
Labels
C-bug Category: This is a bug O-windows Operating system: Windows

Comments

@go2null
Copy link

go2null commented Jun 5, 2023

Summary

I installed helix from within MSYS2 and was very surprised that it behaves as if I had installed it natively in Windows

  • it uses %APPDATA%\helix\config.toml instead of $XDG_CONFIG_HOME/helix/config.toml.
  • it uses %APPDATALOCAL%\helix\config.log instead of $XDG_CACHE_HOME/helix/helix.log.
  • it uses CRLF instead of LF for default EOL.

Reproduction Steps

I tried this:

  1. 1helix`
  2. :new
  3. :write abc.rb

I expected this to happen:

  • File with LF EOL be created

Instead, this happened:

  • File with CRLF EOL be created

Helix log

~/.cache/helix/helix.log
please provide a copy of `~/.cache/helix/helix.log` here if possible, you may need to redact some of the lines

Platform

MSYS2 MinGW UCRT x64

Terminal Emulator

mintty

Helix Version

helix 23.05 (39d0d85d)

@go2null go2null added the C-bug Category: This is a bug label Jun 5, 2023
@the-mikedavis
Copy link
Member

I'm not familiar with MSYS2 or Windows very much but this seems like the right default behavior to me, no? My understanding is that MSYS2 is unix-like but still just Windows, so this would be covered by #6747 and #4378 together

@the-mikedavis the-mikedavis added the O-windows Operating system: Windows label Jun 6, 2023
@the-mikedavis
Copy link
Member

#5621 (#4378 / #3945) has been merged so I think this is now covered just by #6747. I'll close in favor of that but if the default behavior here is not correct we can re-open this / open a new issue

@the-mikedavis the-mikedavis closed this as not planned Won't fix, can't repro, duplicate, stale Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug O-windows Operating system: Windows
Projects
None yet
Development

No branches or pull requests

2 participants