Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: heroku/cli
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v7.46.0
Choose a base ref
...
head repository: heroku/cli
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v7.46.1
Choose a head ref
  • 7 commits
  • 10 files changed
  • 4 contributors

Commits on Oct 20, 2020

  1. Add helpful error message for VaaS MFA users 

    * Soon, we will roll out a beta where users can have MFA/2FA for their
  Heroku Accounts using VaaS (verification as a service), a Salesforce
  platform that all clouds are adopting.
* In the next few months, we will migrate all existing Heroku 2FA users
  over to VaaS. The login experience will still be very similar for
these users, but they will be verifying themselves via the VaaS redirect
interface rather than on the Heroku home-grown 2FA flow.
* Users who are migrated over may not even know it, so they may attempt
  to disable MFA via CLI. While technically we could do some trickery
with the VaaS Admin API to make this possible, the intent of VaaS is
that users go into the VaaS manage page, which is accessible via the
Heroku Dashboard, to do all verifier management.
* This CLI command is used very rarely but we figure it doesn't hurt to
  add a helpful error message here rather than confusingly telling users
with VaaS MFA enabled that they do not have 2FA enabled (because they
do...it's just a *different* 2FA).
* https://gus.my.salesforce.com/a07B0000008TzijIAC
    @fivetanley
    Jessie A. Young authored and fivetanley committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    49f815c View commit details
    Browse the repository at this point in the history

  2. PROPERLY FORMATTED JSON

    @fivetanley
    Jessie A. Young authored and fivetanley committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    da64ece View commit details
    Browse the repository at this point in the history

  3. TIL: indentation matters

    @fivetanley
    Jessie A. Young authored and fivetanley committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    16950b7 View commit details
    Browse the repository at this point in the history

  4. try something similar to cc3f414

    @fivetanley
    Jessie A. Young authored and fivetanley committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    3111384 View commit details
    Browse the repository at this point in the history

  5. ok linter

    @fivetanley
    Jessie A. Young authored and fivetanley committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    3b65e5b View commit details
    Browse the repository at this point in the history

  6. Update packages/auth/src/commands/auth/2fa/disable.ts 

    Co-authored-by: Stanley Stuart <fivetanley@users.noreply.github.com>
    @jessieay @fivetanley
    jessieay and fivetanley committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    b5f9bf6 View commit details
    Browse the repository at this point in the history

  7. v7.46.1

    @fivetanley
    fivetanley committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    d3c36cb View commit details
    Browse the repository at this point in the history
Loading