Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: heroku/cli
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v7.59.1
Choose a base ref
...
head repository: heroku/cli
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v7.59.2
Choose a head ref
  • 2 commits
  • 9 files changed
  • 2 contributors

Commits on Nov 15, 2021

  1. fix(pg-v5): Fix databasename for URLs with query element and be more … 

    …consistent (#1882)

For operations such as pg:psql, we have been assuming that the URL parsed path
method is enough to find the database name. This is incorrect when we pass
parameters such as sslmode. In general, this problem has been solved with
parsePostgresConnectionString but not everything uses it.

This fix removes any custom parsing we are doing of URLs and moves to using
this function everywhere to avoid inconsistency.

* util.databaseNameFromUrl
* util.getConnectionDetails
* the pg:copy resolver

Without this, pg:psql was failing on verify-full URL's but with this patch, it works fine.
    @kbarber
    kbarber committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    5346faf View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2021

  1. v7.59.2 (#1893)

    @tevanoff
    tevanoff committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    77bd720 View commit details
    Browse the repository at this point in the history
Loading