Ctrl+C in pg:psql exiting

[ryanbrainard]

When using pg:psql and pressing Ctrl+C (e.g. to cancel a query), the entire psql process exits instead of being trapped and cancelling the running statement.

I ran into this before and was told to reinstall the CLI. This worked last time, but this is happening again. I reinstalled the CLI again, but still no luck. I am on heroku-cli/6.6.13-57fc242 (darwin-x64) node-v7.9.0.

[msakrejda]

@ryanbrainard does this happen on both private and standard/hobby plans?

[ryanbrainard]

does this happen on both private and standard/hobby plans?

Yes.

[ransombriggs]

@dickeyxxx ^^^ the problem that we had with psql in the ruby removal may also be an issue in v6

[msakrejda]

Interesting, both work fine for me on Ubuntu on v5. Let me see if I can try v6.

[jdx]

I put sigint handling in I'm sure, but something must not be working right. I'll investigate.

[msakrejda]

Yeah, confirmed: on v6 both kill the session for me (whereas on v5 it works fine). Let me know if you need a hand looking at this @dickeyxxx.

[jdx]

will be fixing this this week heroku/cli-engine#162

[jdx]

fix is out, let me know if you still see any issues

[msakrejda]

Confirmed; this works for me as expected with v6.

[mikehale]

I'm seeing this happen again.

[msakrejda]

Works fine for me:

msakrejda@localhost:~$ heroku --version
heroku-cli/6.16.3-4239951 (linux-x64) node-v9.9.0

What version are you running @mikehale?

[mikehale]

➤  heroku --version
heroku-cli/6.16.3-4239951 (darwin-x64) node-v9.9.0

[msakrejda]

Hmm. I tried with both private and standard plans--no issues with either here. Any ideas @jdxcode? Maybe it's only an issue on Macs?

[mikehale]

Ok I think I figured out some steps to reproduce this. It only works on under sudo for cancelling long running queries.

[mikehale]

$  heroku create -n
Creating app... done, ⬢ afternoon-woodland-96428
https://afternoon-woodland-96428.herokuapp.com/ | https://git.heroku.com/afternoon-woodland-96428.git
$  heroku addons:create heroku-postgresql -a afternoon-woodland-96428
Creating heroku-postgresql on ⬢ afternoon-woodland-96428... free
Database has been created and is available
 ! This database is empty. If upgrading, you can transfer
 ! data from another database with pg:copy
Created postgresql-defined-75441 as DATABASE_URL
Use heroku addons:docs heroku-postgresql to view documentation
$  heroku sudo pg:psql -a afternoon-woodland-96428
--> Connecting to postgresql-defined-75441
Expanded display is used automatically.
psql (10.3)
SSL connection (protocol: TLSv1.2, cipher: ECDHE-RSA-AES256-GCM-SHA384, bits: 256, compression: off)
Type "help" for help.

afternoon-woodland-96428::DATABASE=> SELECT pg_sleep(60);
^C%                                                                                                                                                                                                         $  Cancel request sent                                                                                                                                                                                1 ↵
ERROR:  canceling statement due to user request
afternoon-woodland-96428::DATABASE=> \q
select 1
select>
$

[msakrejda]

Ok, I can repro with sudo, but this seems like a sudo plugin bug, no?

[msakrejda]

I did some further testing and pretty sure it's sudo breaking Ctrl-C. Maybe try filing an issue there? Happy to revisit if pg:psql is doing something funky that's causing problems.