Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate possibility to externalize holo-cli into its own repository #12

Closed
frederic-loui opened this issue Apr 7, 2024 · 1 comment
Assignees

Comments

@frederic-loui
Copy link
Member

Investigate possibility to externalize holo-cli into its own repository

Pros:
1- Enforce holo modularization. holo-cli is a GRPC client that can be isolated.
2- Decouple holo-cli to all other software. Net-devs can focus on routing modules while app-devs can focus on cli development.
3- holo node can have holo-cli NOT installed. This reduces code size & surface (good for embedded devices)
4- A sort of holo-cli-ctl installed only on an out of band admin network can be implemented in order to connect multiple holo nodes from a sigle host. (no need to installed software like OpenSSHD on the holo nodes)

Cons:
1- Need to use common holo protobuf and yang definition (can be alleviated with git- submodules)
2- Is having a holo-proto repository worth to add in order to have a better tracking of new features addition/deletion in a central place?
3- holo container needs adjustment in order to include holo software suite and holo-cli

@frederic-loui frederic-loui self-assigned this Apr 7, 2024
rwestphal added a commit that referenced this issue Apr 9, 2024
Add the description field as it's required by crates.io to publish
crates.

The `holo-yang` crate needs to be published since it's used by
`holo-cli`, and `holo-cli` is going to be moved to a separate
repository (see #12).

Eventually, we want all Holo crates on crates.io, but it's too early
for that now.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
@rwestphal
Copy link
Member

Closed by #17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants