Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent shutdown fault-log trace-back #116735

Merged
merged 1 commit into from
May 11, 2024
Merged

Conversation

systemcrash
Copy link
Contributor

Closes issue #116710

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@systemcrash systemcrash requested a review from a team as a code owner May 3, 2024 20:03
@home-assistant home-assistant bot added cla-signed code-quality core small-pr PRs with less than 30 lines. labels May 3, 2024
homeassistant/__main__.py Outdated Show resolved Hide resolved
@home-assistant
Copy link

home-assistant bot commented May 4, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Copy link
Contributor

@elupus elupus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the formatting error.

@home-assistant home-assistant bot marked this pull request as draft May 5, 2024 12:13
@systemcrash systemcrash marked this pull request as ready for review May 6, 2024 11:32
@home-assistant home-assistant bot requested a review from elupus May 6, 2024 11:32
@systemcrash
Copy link
Contributor Author

ping

@elupus elupus merged commit c979597 into home-assistant:dev May 11, 2024
38 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deleted old log fault file: shutdown traceback
2 participants