Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whois integration issues #117805

Open
mkrasowski opened this issue May 20, 2024 · 3 comments
Open

Whois integration issues #117805

mkrasowski opened this issue May 20, 2024 · 3 comments
Assignees

Comments

@mkrasowski
Copy link
Contributor

The problem

The Whois integration doesn't report correct data for some TLDs. Some examples below. This list is definitely not complete.

Invalid/missing attributes for .pl domains (example: hl7.pl):

  • missing expiration date
  • missing last update date

Invalid attributes for .us domains (example: test.us):

  • missing owner
  • invalid registrant

Invalid attributes for .me domains (example: test.me)

  • missing last update date

What version of Home Assistant Core has the issue?

core-2024.5.4

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

whois

Link to integration documentation on our website

https://www.home-assistant.io/integrations/whois/

Diagnostics information

config_entry-whois-001b27fcc94aeeb3cea58274b6a57b68.json

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

The python library HA is using for whois queries has became unsupported
https://pypi.org/project/whois/#description

The recommended replacement is whoisdomain, which has a reported memory leak - mboot-github/WhoisDomain#30, which probably disqualifies it from being used in a long-running application like Home Assistant.

Using an alternative library is discussed in #117749.

@home-assistant
Copy link

Hey there @frenck, mind taking a look at this issue as it has been labeled with an integration (whois) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of whois can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign whois Removes the current integration label and assignees on the issue, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


whois documentation
whois source
(message by IssueLinks)

@Misiu
Copy link
Contributor

Misiu commented May 21, 2024

Sadly, the current library (https://github.com/mboot-github/python-whois) is archived and probably the issues with pl domains won't get fixed.
I think that moving to a new library is the way to go 👍

@Misiu
Copy link
Contributor

Misiu commented Jun 24, 2024

@mkrasowski do you have a custom integration I could try/use?
The current version doesn't work with Polish domains.
Until this gets fixed I'd like to use a working alternative.

EDIT: I just tested https://github.com/richardpenman/whois and it works with my domains

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants