Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump ZHA dependencies #118658

Merged
merged 3 commits into from
Jun 2, 2024
Merged

Bump ZHA dependencies #118658

merged 3 commits into from
Jun 2, 2024

Conversation

puddly
Copy link
Contributor

@puddly puddly commented Jun 2, 2024 •
edited
Loading

Proposed change

Bumps ZHA dependencies:

We recently made the EZSP protocol parsing a little stricter and there are still some commands that were being parsed improperly. One of these is preventing backups from being created when certain firmware versions are installed.

The flasher is bumped as well because it loosely pins bellows to a specific minor version.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@puddly puddly added this to the 2024.6.0 milestone Jun 2, 2024
@home-assistant
Copy link

home-assistant bot commented Jun 2, 2024

Hey there @dmulcahey, @Adminiuga, @TheJulianJES, mind taking a look at this pull request as it has been labeled with an integration (zha) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of zha can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign zha Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@puddly puddly mentioned this pull request Jun 2, 2024
Merged
@dmulcahey dmulcahey merged commit 746939c into home-assistant:dev Jun 2, 2024
38 checks passed
balloob pushed a commit that referenced this pull request Jun 3, 2024
@puddly @balloob
Bump ZHA dependencies (#118658)
3c012c4 
* Bump bellows to 0.39.0

* Do not create a backup if there is no active ZHA gateway object

* Bump universal-silabs-flasher as well
@github-actions github-actions bot locked and limited conversation to collaborators Jun 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dmulcahey dmulcahey dmulcahey approved these changes

@TheJulianJES TheJulianJES TheJulianJES approved these changes

@Adminiuga Adminiuga Awaiting requested review from Adminiuga Adminiuga is a code owner

Assignees

@dmulcahey dmulcahey

@Adminiuga Adminiuga

@TheJulianJES TheJulianJES

Labels
by-code-owner cherry-picked cla-signed dependency has-tests integration: zha Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2024.6.0
Development

Successfully merging this pull request may close these issues.

[ZHA] failed to create backup - timeout
5 participants
@puddly @dmulcahey @TheJulianJES @balloob @Adminiuga