Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toggle flag to combo button #12623

Merged
merged 1 commit into from
Mar 1, 2020
Merged

Conversation

iota97
Copy link
Contributor

@iota97 iota97 commented Feb 12, 2020

Add toggle mode to combo button (the combo button it self will not be hold in down animation, as it would make little sense as other input can override the held and there might be multiple button in the combo).

Should help use cases as #10159 a bit.

EDIT: it swap button separately if one is pressed and the other not when is activated, i dunno what should be the expected behaviour with multiple key toggle tho' (remember the last status and change them all? Loop to check if all have been released by other input before?).

@hrydgard
Copy link
Owner

Hm, are you happy with this as-is? Can't quite tell from the description.

@hrydgard hrydgard added the Input/Controller Input and controller issues label Feb 29, 2020
@hrydgard hrydgard added this to the v1.10.0 milestone Feb 29, 2020
@iota97
Copy link
Contributor Author

iota97 commented Feb 29, 2020

Yeah, I think even if it can be a bit weird with multiple button other solution will end up more confusing/complex with a single one (and i think one button toggle it's a more common use case than multiple ones).

If you want to check how it is now the apk mentioned here have it: #12486 (comment)

@hrydgard hrydgard merged commit b1e83df into hrydgard:master Mar 1, 2020
@iota97 iota97 deleted the sticky-combo branch March 1, 2020 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Input/Controller Input and controller issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants