Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect error instructing to "pip install sklearn" #436

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix incorrect error instructing to "pip install sklearn" #436

wants to merge 1 commit into from

Conversation

dongreenberg
Copy link

Fixes #394, and what I imagine is a frequent trip-up for people who forget that the correct pypi package name is "scikit-learn."

@dongreenberg
Fix incorrect error instructing to "pip install sklearn"
7629648 
Fixes huggingface#394, and what I imagine is a frequent trip-up for people who forget that the correct pypi package name is "scikit-learn".
lvwerra
lvwerra approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@lvwerra lvwerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, looks good!

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@lvwerra
Copy link
Member

lvwerra commented Apr 13, 2023

Can you run make style && make quality to fix the style tests?

@bzz bzz mentioned this pull request Sep 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvwerra lvwerra lvwerra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@dongreenberg @HuggingFaceDocBuilderDev @lvwerra