-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
several breakages due to recent datasets
#542
Comments
umask
isn't being respected when creating lock filesdatasets
datasets
datasets
@lhoestq, I updated the OP and was able to bisect which package and version lead to the breakage. |
It seems to be an issue with recent versions of Can you try using an older version ? e.g. I use 3.9.0 which seems to work fine:
|
I just opened huggingface/datasets#6631 in Can you try it out ? Once I have your green light I can make a new release |
thanks a lot, @lhoestq @williamberrios - could you please test this asap and if all started working they can make a new release - thank you! |
Hi @lhoestq, |
Thank you for confirming it solved your problem, William! |
Problem 2 is affecting me too. Downgrading fixed it but it frustrates me that I have to downgrade filelock on every machine I want to use multi-node evaluate on; is there another workaround? Can we get this fixed @stas00? |
Not sure why you've tagged me, Jack ;) I have just reported the problem on behalf of my colleague. |
sorry :) |
@lhoestq, is it possible to make a new release now that this issue has been fixed? Thank you! |
just released 0.4.2 :) |
Thank you very much, Quentin! |
Unfortunately, I'm facing the same error with the latest versions of evaluate (0.4.2), datasets (2.20.2) and filelock (3.15.4). Downgrading datasets/filelock also doesn't seem to fix the issue for me inspite of having the lockfiles in the cache_dir. |
Hi, |
Unfortunately not. |
I could take a look if you can provide a google colab or script that reproduces the issue :) |
It seems that
datasets==2.16.0
and higher breaksevaluate
Problem 1.
umask
isn't being respected when creating lock filesas we are in a group setting we use
umask 000
but this script creates files with missing perms:
which is invalid, since
umask 000
should have led to:the problem applies to all other locks created during such run - that is a few more .lock files there.
this is the same issue that was reported and dealt with multiple times in
datasets
if I downgrade to
datasets==2.15.0
the files are created correctly with:Problem 2.
Expected to find locked file /data/huggingface/metrics/accuracy/default/test4-2-0.arrow.lock from process 1 but it doesn't exist.
The files are there:
if I downgrade to
datasets==2.15.0
the above code starts to work.with
datasets<2.16
works,datasets>=2.16
breaks.Using
evaluate==0.4.1
Thank you!
@lhoestq
@williamberrios who reported this
The text was updated successfully, but these errors were encountered: