Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[with solution]: problem with lineWidthStack #53

Closed
tmarti opened this issue Nov 4, 2019 · 2 comments · Fixed by #52
Closed

[with solution]: problem with lineWidthStack #53

tmarti opened this issue Nov 4, 2019 · 2 comments · Fixed by #52
Assignees
@jtenner
Labels
bug

Comments

@tmarti
Copy link

tmarti commented Nov 4, 2019

This line...

jest-canvas-mock/src/classes/CanvasRenderingContext2D.js

Line 1116 in d895824

this._lineWidthStack.push(this._lineWidthStack[this.stackIndex]);

... should be replaced with:

this._lineWidthStack.push(this._lineWidthStack[this._stackIndex]);

Notice the missing _ when accessing this._stackIndex.

Sorry for not submitting a PR 😜
@jtenner jtenner self-assigned this Nov 4, 2019
@jtenner jtenner added the bug label Nov 4, 2019
@jtenner
Copy link
Collaborator

jtenner commented Nov 4, 2019

What's really alarming is the lineWidth isn't being properly tested.

@jtenner jtenner mentioned this issue Nov 4, 2019
Merged
@jtenner
Copy link
Collaborator

jtenner commented Nov 4, 2019

Thanks @tmarti this should be fixed in #52

@hustcc hustcc closed this as completed in #52 Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jtenner jtenner

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(transform): slice transform on save, node 13 jtenner/jest-canvas-mock
2 participants
@tmarti @jtenner