From e458d68a3879d968faa1da9de38876e23935c166 Mon Sep 17 00:00:00 2001 From: Ivan Diaz Sanchez Date: Thu, 11 Jan 2024 14:37:40 -0800 Subject: [PATCH] Add ActiveIssue Annotations to Failing TestReadyToRun Tests and Reenable the Executables (#96721) * Add "ActiveIssue" annotation placeholders to the failing tests, and reenable their respective executables, so that the other tests in said run can be executed. * Added "ActiveIssue" annotation to failing Threading test. * Added the ActiveIssue annotation to AppDomain.cs * Added the ActiveIssue template in FileSystemWatcher.File.Move.cs * Commented out an ActiveIssue annotation because I need to check on something in CI. * Reenabled another failing test because I need to see it in CI. * Yet another test being weird... * Disabled some Serialization tests after confirming in CI that they indeed not work. * Removed unneeded? commented out ActiveIssue annotation. --- .../Microsoft.XmlSerializer.Generator/tests/SGenTests.cs | 1 + .../tests/FileSystemWatcher.File.Move.cs | 1 + .../tests/XmlSerializer/XmlSerializerTests.cs | 1 + .../System/AppDomainTests.cs | 1 + .../System.Threading.Thread/tests/ThreadTests.cs | 1 + src/libraries/tests.proj | 9 --------- 6 files changed, 5 insertions(+), 9 deletions(-) diff --git a/src/libraries/Microsoft.XmlSerializer.Generator/tests/SGenTests.cs b/src/libraries/Microsoft.XmlSerializer.Generator/tests/SGenTests.cs index b9d896e6537fd..15f9dfd3999b7 100644 --- a/src/libraries/Microsoft.XmlSerializer.Generator/tests/SGenTests.cs +++ b/src/libraries/Microsoft.XmlSerializer.Generator/tests/SGenTests.cs @@ -12,6 +12,7 @@ namespace Microsoft.XmlSerializer.Generator.Tests public static class SgenTests { [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/96796", typeof(PlatformDetection), nameof(PlatformDetection.IsReadyToRunCompiled))] public static void SgenCommandTest() { /* diff --git a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Move.cs b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Move.cs index a5515c4837331..e03ebc8ee92a8 100644 --- a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Move.cs +++ b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Move.cs @@ -185,6 +185,7 @@ private void FileMove_DifferentWatchedDirectory(WatcherChangeTypes eventType) } } + [ActiveIssue("https://github.com/dotnet/runtime/issues/96728", typeof(PlatformDetection), nameof(PlatformDetection.IsReadyToRunCompiled))] private void FileMove_FromWatchedToUnwatched(WatcherChangeTypes eventType) { string dir_watched = CreateTestDirectory(TestDirectory, "dir_watched"); diff --git a/src/libraries/System.Private.Xml/tests/XmlSerializer/XmlSerializerTests.cs b/src/libraries/System.Private.Xml/tests/XmlSerializer/XmlSerializerTests.cs index 51a961a0befc2..649f53108380c 100644 --- a/src/libraries/System.Private.Xml/tests/XmlSerializer/XmlSerializerTests.cs +++ b/src/libraries/System.Private.Xml/tests/XmlSerializer/XmlSerializerTests.cs @@ -2101,6 +2101,7 @@ public static void Xml_TypeWithSpecialCharacterInStringMember() [SkipOnPlatform(TestPlatforms.Browser, "AssemblyDependencyResolver not supported in wasm")] #endif [ActiveIssue("34072", TestRuntimes.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/96799", typeof(PlatformDetection), nameof(PlatformDetection.IsReadyToRunCompiled))] public static void Xml_TypeInCollectibleALC() { ExecuteAndUnload("SerializableAssembly.dll", "SerializationTypes.SimpleType", out var weakRef); diff --git a/src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/AppDomainTests.cs b/src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/AppDomainTests.cs index 2e9b02c77e612..f473d1dec8276 100644 --- a/src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/AppDomainTests.cs +++ b/src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/AppDomainTests.cs @@ -46,6 +46,7 @@ public void RelativeSearchPath_Is_Null() [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.HasHostExecutable))] [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.Android | TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst, "The dotnet sdk will not be available on these platforms")] + [ActiveIssue("https://github.com/dotnet/runtime/issues/96727", typeof(PlatformDetection), nameof(PlatformDetection.IsReadyToRunCompiled))] public void TargetFrameworkTest() { const int ExpectedExitCode = 0; diff --git a/src/libraries/System.Threading.Thread/tests/ThreadTests.cs b/src/libraries/System.Threading.Thread/tests/ThreadTests.cs index 8d0f73598ecc2..faad4bebd6af1 100644 --- a/src/libraries/System.Threading.Thread/tests/ThreadTests.cs +++ b/src/libraries/System.Threading.Thread/tests/ThreadTests.cs @@ -168,6 +168,7 @@ public static IEnumerable ApartmentStateTest_MemberData() [InlineData("DefaultApartmentStateMain.exe", "GetApartmentStateTest")] [InlineData("DefaultApartmentStateMain.exe", "SetApartmentStateTest")] [ActiveIssue("https://github.com/dotnet/runtime/issues/34543", TestPlatforms.Windows, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/86722", typeof(PlatformDetection), nameof(PlatformDetection.IsReadyToRunCompiled))] public static void ApartmentState_AttributePresent(string appName, string testName) { var psi = new ProcessStartInfo(); diff --git a/src/libraries/tests.proj b/src/libraries/tests.proj index ce3beb31ecc92..9bc2659d3e0c3 100644 --- a/src/libraries/tests.proj +++ b/src/libraries/tests.proj @@ -618,20 +618,11 @@ Tracking Issue for this work item: https://github.com/dotnet/runtime/issues/95928 --> - - - - - - - - -