Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project has both package-lock.json and yarn.lock files. #73

Closed
alexanderl19 opened this issue Apr 9, 2023 · 1 comment · Fixed by #96
Closed

Project has both package-lock.json and yarn.lock files. #73

alexanderl19 opened this issue Apr 9, 2023 · 1 comment · Fixed by #96

Comments

@alexanderl19
Copy link
Member

The icssc-website repo has both a package-lock.json and yarn.lock file.
This is suboptimal because it can create edge cases where two versions of dependencies are used to develop, test, and deploy the site.

We've been adopting pnpm throughout ICSSC Projects. Switching to pnpm, or removing either package-lock.json and yarn.lock would solve this issue.

@sirAvent
Copy link
Member

I say remove yarn.lock. If I remember correctly, I added it on accident messing around with initial setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants