Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Normal Modal): Frame Definability of ๐†๐‹ #24

Merged
merged 9 commits into from
Feb 15, 2024
Merged

feat(Normal Modal): Frame Definability of ๐†๐‹ #24

merged 9 commits into from
Feb 15, 2024

Conversation

SnO2WMaN
Copy link
Member

@SnO2WMaN SnO2WMaN commented Feb 10, 2024 •
edited
Loading

close #18

  1. ๐†๐‹ใฏๆŽจ็งป็š„ใ‹ใค้€†ๆ•ด็คŽใชใƒ•ใƒฌใƒผใƒ ใ‚’่ฆๅฎšใ™ใ‚‹
  2. ๐†๐‹ใฏๆŽจ็งป็š„ใ‹ใค้žๅๅฐ„็š„ใชๆœ‰้™ใƒ•ใƒฌใƒผใƒ ใ‚’่ฆๅฎšใ™ใ‚‹

TODO

  • ่‡ชๆ˜Žใช๐†๐‹ใฎใƒ•ใƒฌใƒผใƒ ใฎไพ‹๏ผˆๅญ˜ๅœจใ™ใ‚ŒใฐโŠฌแดน[๐†๐‹]! โŠฅ๏ผ‰
  • README.mdใฎๆ›ดๆ–ฐ: G. Boolos; "The Logic of Provability" ใฎ่ฟฝๅŠ 

Memo

ใ„ใใคใ‹ใฎๅฎš็พฉใ‚’ๅˆฉ็”จใ—ใฆใ„ใ‚‹ใฎใง #23 ใฎๅพŒใซmergeใ™ใ‚‹

@SnO2WMaN SnO2WMaN changed the title feat(Normal Modal): Frame definability of ๐†๐‹ feat(Normal Modal): Frame Definability of ๐†๐‹ Feb 10, 2024
@SnO2WMaN SnO2WMaN mentioned this pull request Feb 15, 2024
Merged
@SnO2WMaN
Copy link
Member Author

#26 ใ‚’ใƒžใƒผใ‚ธใ—ๆฌก็ฌฌใ“ใฎPRใ‚‚ใƒžใƒผใ‚ธๅฏ่ƒฝใงใ™๏ผŽไธ€้ƒจใ‚ณใƒŸใƒƒใƒˆใŒ้‡่ค‡ใ—ใฆใ„ใ‚‹ใ‹ใ‚‰squashใƒžใƒผใ‚ธใฎใปใ†ใŒ่‰ฏใ„ใจๆ€ใ†๏ผŽ

@SnO2WMaN SnO2WMaN marked this pull request as ready for review February 15, 2024 11:46
iehality
iehality reviewed Feb 15, 2024
View reviewed changes
Logic/Modal/Normal/GL/Semantics.lean Show resolved Hide resolved
Logic/Modal/Normal/GL/Semantics.lean Outdated Show resolved Hide resolved
Logic/Modal/Normal/Semantics.lean Outdated Show resolved Hide resolved
Logic/Modal/Normal/GL/Semantics.lean Show resolved Hide resolved
@SnO2WMaN
Copy link
Member Author

rebaseใ—็›ดใ—ใŸใฎใงใ“ใ‚Œใงใƒžใƒผใ‚ธๅ‡บๆฅใ‚‹ใจๆ€ใ†๏ผŽ

@iehality iehality merged commit 57beee5 into FormalizedFormalLogic:master Feb 15, 2024
1 check passed
@SnO2WMaN SnO2WMaN deleted the SnO2WMaN/issue18 branch February 15, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iehality iehality iehality left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Frame class definability of GL
2 participants
@SnO2WMaN @iehality