-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Prevent duplicate HTML IDs on photo page #6356
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6356 +/- ##
==========================================
- Coverage 88.69% 88.68% -0.01%
==========================================
Files 290 290
Lines 40390 40422 +32
==========================================
+ Hits 35823 35848 +25
- Misses 4567 4574 +7
|
This will break anyone that is used to typing http://localhost:8000/wg/photos/#h to get to the h's. It also just pushes the problem down the road (this problem exists on the current page) on doing the right thing with real names. Someone with a non [a-zA-Z] first character will end up with a section that is labelled with an [a-zA-Z] heading that is sorted in nothing matching any standardized collation. Are ids restricted to [a-zA-Z]? Could we just use the first unicode character instead and make sure the results are sorted with the system's collation setting? This template is only used for working group chairs, so we're not likely to have random garbage thrown at production. |
We could. Let me see if I can rework this. |
Turns out HTML5 IDs can be Unicode :-) |
Fixes #6355