-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove incorrect line from submission API info web page #6432
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the patch - as noted inline, only the asynchronous endpoint (api_submission
) accepts replacement information so we should probably keep the comment on the old endpoint's docs.
@@ -27,7 +27,6 @@ <h1 class="mb-3">Internet-Draft submission API instructions</h1> | |||
</p> | |||
<ul> | |||
<li>Only XML-only uploads are supported, not text or combined.</li> | |||
<li>Document replacement information cannot be supplied.</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one needs to stay - the replaces is only supported through the asynchronous endpoint.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah good catch, thanks! Fixed.
Codecov Report
@@ Coverage Diff @@
## main #6432 +/- ##
==========================================
- Coverage 88.81% 88.69% -0.12%
==========================================
Files 290 290
Lines 40879 40429 -450
==========================================
- Hits 36305 35857 -448
+ Misses 4574 4572 -2
|
Now that #4037 has landed and #3286 has been resolved, this line can be removed.