Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove incorrect line from submission API info web page #6432

Merged
merged 3 commits into from
Oct 9, 2023

Conversation

DavidSchinazi
Copy link
Contributor

Now that #4037 has landed and #3286 has been resolved, this line can be removed.

@DavidSchinazi DavidSchinazi changed the title Remove incorrect line from submission API info web page fix: Remove incorrect line from submission API info web page Oct 4, 2023
Copy link
Member

@jennifer-richards jennifer-richards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the patch - as noted inline, only the asynchronous endpoint (api_submission) accepts replacement information so we should probably keep the comment on the old endpoint's docs.

@@ -27,7 +27,6 @@ <h1 class="mb-3">Internet-Draft submission API instructions</h1>
</p>
<ul>
<li>Only XML-only uploads are supported, not text or combined.</li>
<li>Document replacement information cannot be supplied.</li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one needs to stay - the replaces is only supported through the asynchronous endpoint.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good catch, thanks! Fixed.

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #6432 (6ba48cb) into main (c5a955d) will decrease coverage by 0.12%.
Report is 27 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #6432      +/-   ##
==========================================
- Coverage   88.81%   88.69%   -0.12%     
==========================================
  Files         290      290              
  Lines       40879    40429     -450     
==========================================
- Hits        36305    35857     -448     
+ Misses       4574     4572       -2     
Files Coverage Δ
ietf/doc/views_statement.py 94.96% <ø> (ø)
ietf/nomcom/urls.py 100.00% <ø> (ø)
ietf/nomcom/utils.py 91.42% <ø> (-2.01%) ⬇️
ietf/nomcom/views.py 93.00% <ø> (-1.62%) ⬇️

... and 1 file with indirect coverage changes

@rjsparks rjsparks merged commit 5e0d1be into ietf-tools:main Oct 9, 2023
9 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants