Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add "add comment" feature to the review requests. #6603

Merged
merged 1 commit into from
Nov 5, 2023

Conversation

kivinen
Copy link
Contributor

@kivinen kivinen commented Nov 4, 2023

Fixes #5979. Add missing tbody/tbody to review_request.html.

Copy link

codecov bot commented Nov 4, 2023

Codecov Report

Merging #6603 (6c0cb4d) into main (d246879) will increase coverage by 0.01%.
Report is 2 commits behind head on main.
The diff coverage is 95.45%.

@@            Coverage Diff             @@
##             main    #6603      +/-   ##
==========================================
+ Coverage   88.85%   88.86%   +0.01%     
==========================================
  Files         284      284              
  Lines       40253    40275      +22     
==========================================
+ Hits        35765    35790      +25     
+ Misses       4488     4485       -3     
Files Coverage Δ
ietf/doc/urls_review.py 100.00% <ø> (ø)
ietf/review/models.py 92.85% <100.00%> (+0.88%) ⬆️
ietf/doc/views_review.py 95.14% <94.73%> (-0.02%) ⬇️

... and 3 files with indirect coverage changes

@rjsparks rjsparks merged commit 53d0014 into ietf-tools:main Nov 5, 2023
9 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

secretaries (review team and the secretariat) should be able to add comments to a review requests's history
2 participants