Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replay icon display on iOS #469

Closed
andreinegrea14 opened this issue Aug 19, 2021 · 6 comments
Closed

Replay icon display on iOS #469

andreinegrea14 opened this issue Aug 19, 2021 · 6 comments
Labels
bug Something isn't working

Comments

@andreinegrea14
Copy link

andreinegrea14 commented Aug 19, 2021

I can't get over a bug that occurs on iOS only, the replay icon do not appear immediately after the video finished. The behavior is this: the video ends, play icon appears, if play icon is pressed the icon switches to replay.

Expected behavior
The expected behavior is that the replay icon appears after the video ends, not the play icon. Did not had this issue on android.

Additional information:

  • Type: Both Simulator & iPhone device
  • Device: Any
  • OS: iOS 14.0+
  • Package version 2.0.1
  • Expo version 39

Is this a singular issue ? I didn't find any related issues here.

@andreinegrea14 andreinegrea14 added the bug Something isn't working label Aug 19, 2021
@ihmpavel
Copy link
Owner

That is weird. Unfortunately I am not able to reproduce, but I will be happy to merge a fix :/

@MadhavNasit
Copy link

MadhavNasit commented Nov 12, 2021

I can't get over a bug that occurs on iOS only, the replay icon do not appear immediately after the video finished. The behavior is this: the video ends, play icon appears, if play icon is pressed the icon switches to replay.

Expected behavior The expected behavior is that the replay icon appears after the video ends, not the play icon. Did not had this issue on android.

Additional information:

  • Type: Both Simulator & iPhone device
  • Device: Any
  • OS: iOS 14.0+
  • Package version 2.0.1
  • Expo version 39

Is this a singular issue ? I didn't find any related issues here.

+1 , @andreinegrea14 any solution?

@MadhavNasit
Copy link

MadhavNasit commented Nov 12, 2021

That is weird. Unfortunately I am not able to reproduce, but I will be happy to merge a fix :/

@ihmpavel, replace below lines in index.js in dist on line no. 112 of updatePlaybackCallback function,
position: status.positionMillis, duration: status.durationMillis || 0, state: status.didJustFinish
with
position: status.positionMillis, duration: status.durationMillis || 0, state: status.positionMillis == status.durationMillis

@ihmpavel
Copy link
Owner

Hi, this will solve this issue?
If so I'll be happy to accept PR/create PR from this

@OneHatRepo
Copy link

Solved it for me! Can you please merge it in?

@ihmpavel
Copy link
Owner

Get ready for new version 2.0.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants