Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix high severity issues reported by SonarCloud #2865

Open
iluwatar opened this issue Mar 29, 2024 · 7 comments
Open

Fix high severity issues reported by SonarCloud #2865

iluwatar opened this issue Mar 29, 2024 · 7 comments
Labels
epic: code quality info: good first issue info: help wanted

Comments

@iluwatar
Copy link
Owner

SonarCloud is used for static code analysis. It currently reports 48 high severity issues.

See https://sonarcloud.io/project/issues?impactSeverities=HIGH&resolved=false&id=iluwatar_java-design-patterns

It is possible to run the same analysis on local machine using SonarLint plugin. See instructions at https://github.com/iluwatar/java-design-patterns/wiki/12.-IDE-instructions

Acceptance criteria

  • High severity issues reported by SonarCloud have been fixed
@iluwatar
Copy link
Owner Author

iluwatar commented May 4, 2024

Most of the high severity issues fixed by @k1w1dev, but still 18 remain. See https://sonarcloud.io/project/issues?impactSeverities=HIGH&resolved=false&id=iluwatar_java-design-patterns

@iluwatar iluwatar reopened this May 4, 2024
@krishnagjsForGit
Copy link

I can start on these remaining issues.

@stale Stale
Copy link

stale bot commented Aug 14, 2024

This issue has been automatically marked as stale because it has not had recent activity. The issue will be unassigned if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status: stale issues and pull requests that have not had recent interaction label Aug 14, 2024
@stale stale bot removed the status: stale issues and pull requests that have not had recent interaction label Sep 22, 2024
@PALASH2201
Copy link

I'm new here, are all the issues fixed?

@PALASH2201
Copy link

PALASH2201 commented Oct 1, 2024 •
edited
Loading

I went to through this analysis https://sonarcloud.io/project/issues?impactSeverities=HIGH&resolved=false&id=iluwatar_java-design-patterns , mongoDB credentials were hardcoded, so I have added .env file and tested the changes, I have also added and updated dependencies in pom.xml. I have tested and it has passed. How to proceed now?

@PALASH2201
Copy link

Should I issue a PR for your review?

@PALASH2201
Copy link

@iluwatar I apologize for pinging you, but is this issue solved already, I have made some changes, just need your approval

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
epic: code quality info: good first issue info: help wanted
Projects
Java Design Patterns project
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
4 participants
@iluwatar @krishnagjsForGit @PALASH2201 and others