Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Commander #2978

Closed
iluwatar opened this issue Jun 1, 2024 · 2 comments · Fixed by #2983
Closed

Refactor Commander #2978

iluwatar opened this issue Jun 1, 2024 · 2 comments · Fixed by #2983
Labels
epic: code quality info: good first issue info: help wanted

Comments

@iluwatar
Copy link
Owner

iluwatar commented Jun 1, 2024

Description

Commander pattern has some dead code and it should be refactored. At the moment it has 4 different App classes and main functions. Each App's main function only executes the success case, but not the failure cases (dead code).

Acceptance Criteria

  • 4 App classes refactored into one
  • There is only one main function
  • The main function executes all the success cases and the failure cases
@Mayankchoudhary294
Copy link
Contributor

Hello @iluwatar
Do you mean to refactor all 5 App classes into one, with the main function executing both the success and failure cases?

@iluwatar
Copy link
Owner Author

iluwatar commented Jun 3, 2024

Yes, I think that would make the example easier to use and understand.

Mayankchoudhary294 pushed a commit to Mayankchoudhary294/java-design-patterns that referenced this issue Jun 3, 2024
Resolved issue iluwatar#2978 Refactor Commander
b80d470
This was referenced Jun 3, 2024
Closed
Merged
iluwatar pushed a commit that referenced this issue Jun 4, 2024
@Mayankchoudhary294
refactor: Refactor commander (#2983)
ed90c41 
* Resolved issue #2978 Refactor Commander

* Fixed checkstyle issues

---------

Co-authored-by: Mayankchoudhary294 <mayankchoudhary4302@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
epic: code quality info: good first issue info: help wanted
Projects
Java Design Patterns project
Archived in project
Milestone
No milestone
2 participants
@iluwatar @Mayankchoudhary294