Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

range selection in line chart #988

Closed
wants to merge 3 commits into from
Closed

Conversation

takassh
Copy link

@takassh takassh commented May 4, 2022

Hi, thank you for publishing this great package!
It helps us much.
I found an issue and I want to contribute it.
I understand you are busy, but I'm happy if you take a look.

fixes #131 #786

RPReplay_Final1651653962.MP4

@takassh takassh changed the title implement multi tap range selection in line chart May 4, 2022
@takassh
Copy link
Author

takassh commented May 4, 2022

cc @imaNNeoFighT

@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #988 (d2e32c7) into master (b0e3027) will increase coverage by 0.40%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #988      +/-   ##
==========================================
+ Coverage   85.17%   85.57%   +0.40%     
==========================================
  Files          42       42              
  Lines        2731     2718      -13     
==========================================
  Hits         2326     2326              
+ Misses        405      392      -13     
Impacted Files Coverage Δ
lib/src/chart/line_chart/line_chart.dart 0.00% <0.00%> (ø)
lib/src/chart/bar_chart/bar_chart_renderer.dart 100.00% <0.00%> (+22.72%) ⬆️
...ib/src/chart/radar_chart/radar_chart_renderer.dart 100.00% <0.00%> (+22.72%) ⬆️
...rc/chart/scatter_chart/scatter_chart_renderer.dart 100.00% <0.00%> (+22.72%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@takassh takassh marked this pull request as ready for review May 13, 2022 02:58
@imaNNeo
Copy link
Owner

imaNNeo commented Jan 30, 2023

Actually, you are implementing multi-touch support. Correct?
Also, you need to rebase and resolve your conflicts. I am sorry for my delay.

@imaNNeo imaNNeo closed this Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add range selection to line chart
2 participants