Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance on calculating minX, maxX, minY and maxY in axis-based charts #1693

Open
imaNNeo opened this issue Jun 21, 2024 · 0 comments

Comments

@imaNNeo
Copy link
Owner

imaNNeo commented Jun 21, 2024

There was a memory leak issue on caching the calculated values here: #1106
We removed the caching logic to fix the memory issue by accepting the computation cost trade-off for now (because we don't have a quick solution for it)

The solution is moving the caching logic into the renderer objects. We can keep and update the calculated values only when the data is changed (as you know renderer objects remain the same as long as we have the widget in the widget tree)

So I just created this issue to follow up this improvement for later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant