Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompressionMethod and PhotometricInterpretation should be NonExhaustive #59

Closed
HeroicKatora opened this issue Oct 2, 2019 · 1 comment

Comments

@HeroicKatora
Copy link
Member

This is a small compatibility hazard, the only enum variants are the currently supported or introduced variants for these two (and potentially other) fields in tiff. Adding new variants breaks user code that matches on them, it would be customary to use instead an explicit __NonExhaustive variant that is not publicly documented and explicitely should not be matched against.

@HeroicKatora
Copy link
Member Author

Tag could be non exhaustive as well. Adding detection for now tags, effectively moving from Unknown to a new known variant such as potentially suggested in #47, does not require a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant