-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make local cluster start idempotent #1031
Comments
One possible solution to this is to make the SC create a pid lockfile when it starts up, something like |
This needs to work across different OS and cluster types (local,k8). We certainly need Key points
Note that this is |
Stale issue message |
Stale issue message |
Stale issue message |
@sehz Since #2044 added a check for a running local cluster, is a |
Yes, it's OK to return a non-recoverable error. |
@sehz Sorry, I think I wasn't clear; those are errors that already exist in the code, and are considered "nonrecoverable" (they're part of the |
If we try to start a cluster twice, we don't always get useful error messages.
This error manifests during development often. We might forget that we have a local cluster started. Or we used to have a cluster started locally, but we've killed the process.
In my opinion, there are 2 different levels to address this.
fluvio cluster start
(Kubernetes).If a cluster appears to be running, we just say so. Otherwise, we suggest running
fluvio cluster delete --local
to clean up metadata.ex. Successful kubernetes startup idempotency
In my mind, this is effectively running
fluvio cluster delete --local && fluvio cluster start --local
on behalf of the user. We can inform them while we are cleaning up.We could have option 1 be the default behavior, and provide option 2 behind a
--force
flag. The goal in mind is a scriptable path to starting a local cluster w/o needing to handle errors.The text was updated successfully, but these errors were encountered: