Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate code for all google.protobuf types #1445

Closed
romac opened this issue Jul 17, 2024 · 0 comments · Fixed by #1452
Closed

Generate code for all google.protobuf types #1445

romac opened this issue Jul 17, 2024 · 0 comments · Fixed by #1452

Comments

@romac
Copy link
Member

romac commented Jul 17, 2024

@tony-iqlusion:

Sidebar: in cosmos-sdk-proto and ibc-proto we've discussed ditching prost-types and generating the google.protobuf protos directly from the protobuf schema using the same conventions as everything else, which among other things allows integrations with pbjson for building JSON serializers /cc @romac

See discussion here: cosmos/cosmos-rust#459 (review)

@romac:

We should probably generate code for all google.protobuf types (ie. including Any) instead of copy-pasting a subset of it, and then use those directly from ibc-proto-rs instead of the latter having its own copy of them.

Otherwise one cannot pass a tendermint_proto Duration where an ibc-proto Duration is expected and vice-versa, same for the other well-known types.

Originally posted by @romac in #1444 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant