Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable delete via IP address #2

Open
alexellis opened this issue Oct 29, 2019 · 6 comments
Open

Enable delete via IP address #2

alexellis opened this issue Oct 29, 2019 · 6 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@alexellis
Copy link
Member

Expected Behaviour

After provisioning and coming back later, an inlets exit-node will be known mainly by its IP rather than the internal ID used by the cloud provider.

We could do something like this for a friendlier experience:

inlets delete --ip 209.97.131.180

Current Behaviour

We delete via an ID

inlets delete --id 164857028

Possible Solution

if --ip is given, iterate and page through the instances the cloud provider has (filtered by tag?) and match on IP, then use that ID to run the deletion.

This is a follow-on feature from #1

@alexellis alexellis added bug Something isn't working help wanted Extra attention is needed labels Oct 29, 2019
@alexellis alexellis added enhancement New feature or request good first issue Good for newcomers and removed bug Something isn't working labels Nov 11, 2019
@alexellis
Copy link
Member Author

Removing incorrect label of "bug"

@adamjohnson01
Copy link
Contributor

@alexellis , I will do this one as well.

@alexellis
Copy link
Member Author

Thanks 👍

This is going to be rather more involved I think, but would be awesome to have.

In the meantime, can you also send a PR to update the create command so that it prints the sample delete command?

@adamjohnson01
Copy link
Contributor

In the meantime, can you also send a PR to update the create command so that it prints the sample delete command?

Sure, will do!

@adamjohnson01
Copy link
Contributor

@alexellis, as part of #21 I created a method for each provisioner called List. We could potentially create a new cmd called list that will list all of the exit nodes for the specified provisioner. Let me know what you think.

@adamjohnson01
Copy link
Contributor

@alexellis , this can be closed as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants