Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

Fix CAR and other metrics #76

Closed
7 tasks done
lidel opened this issue Apr 4, 2023 · 3 comments
Closed
7 tasks done

Fix CAR and other metrics #76

lidel opened this issue Apr 4, 2023 · 3 comments

Comments

@lidel
Copy link
Collaborator

lidel commented Apr 4, 2023

Some things I've noticed while adding CAR panels to bifrost-gw staging (see "bifrost-gateway daemon" section)

I think the first step is to add more buckets beyond 1m, let's say until 5m.

@lidel lidel changed the title Fix CAR metrics Fix CAR and other metrics Apr 4, 2023
@willscott
Copy link
Collaborator

  • I don't see limits for 4MiB / 1min in caboose code anywhere obvious - i wonder if these are limits imposed from the saturn side?

@aarshkshah1992
Copy link
Collaborator

aarshkshah1992 commented Apr 5, 2023

@willscot @lidel

Identified RC for #75 . filecoin-saturn/caboose#77

4Mib was because of using block size buckets for CAR size histrogram. The above PR takes care of that.

@lidel
Copy link
Collaborator Author

lidel commented Apr 5, 2023

Thanks @aarshkshah1992!

Closed in 185727b (filecoin-saturn/caboose#77) and d8d2849 (ipfs/boxo#265)

@lidel lidel closed this as completed Apr 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants