Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript projects cannot update to new aegir #709

Closed
vasco-santos opened this issue Dec 29, 2020 · 1 comment
Closed

Typescript projects cannot update to new aegir #709

vasco-santos opened this issue Dec 29, 2020 · 1 comment
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@vasco-santos
Copy link
Member

  • OS: *
  • Version: 0.29.0 (or further)

When updating a typescript project to use aegir with typescript declaration files being generated on build time, typescript projects like https://github.com/ChainSafe/js-libp2p-gossipsub fail to build.

> libp2p-gossipsub@0.8.0 prebuild /Users/vsantos/work/gh/libp2p/gossipsub-js
> tsc


> libp2p-gossipsub@0.8.0 build /Users/vsantos/work/gh/libp2p/gossipsub-js
> aegir build

error TS18003: No inputs were found in config file '/Users/vsantos/work/gh/libp2p/gossipsub-js/tsconfig-types.aegir.json'. Specified 'include' paths were '["src","package.json"]' and 'exclude' paths were '["./src"]'.

This project has its own tsconfig file that seems to cause conflicts with aegir.

There are two possibilities here that I can see:

@vasco-santos vasco-santos added the kind/bug A bug in existing code (including security flaws) label Dec 29, 2020
@hugomrdias
Copy link
Member

They should just do npx aegir build --no-types since they build .d.ts in another way.
Also the TS cmds work nicer with custom configs in the latest versions.

Please re-open if you think more discussion is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Development

No branches or pull requests

2 participants