Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When response has a network send error, and is cancelled, remove all queued packets for this request #314

Closed
hannahhoward opened this issue Dec 13, 2021 · 0 comments · Fixed by #320
Assignees
Labels
need/triage Needs initial labeling and prioritization

Comments

@hannahhoward
Copy link
Collaborator

What

When processing a response, several packets get queued up to go over the libp2p stream. Let's imagine it as such:

Message1 ... Message 2 ... Message 3 ... Message 4 ... Message 5 ... Message 6 ...

If message 3 fails to send, this will cancel the whole response with an error. That's expect.

However, message 4, 5, & 6 will still attempt to send, most likely failing but possibly much later. Data transfer often listens to these fails and may misinterpret them if they arrive late (seperate issue)

When message 3 fails to send, we should trace back through the message queue and cancel any pending messages for any responses that were part of the failed message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/triage Needs initial labeling and prioritization
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant