Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #7624: Do not fetch dag nodes when checking if a pin exists #7625

Merged
merged 2 commits into from
Aug 26, 2020

Conversation

hsanjuan
Copy link
Contributor

No description provided.

@hsanjuan hsanjuan self-assigned this Aug 26, 2020
@@ -57,9 +57,9 @@ func (api *PinAPI) Ls(ctx context.Context, opts ...caopts.PinLsOption) (<-chan c
}

func (api *PinAPI) IsPinned(ctx context.Context, p path.Path, opts ...caopts.PinIsPinnedOption) (string, bool, error) {
dagNode, err := api.core().ResolveNode(ctx, p)
resolved, err := api.core().ResolvePath(ctx, p)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed by ipfs/go-path#30

@aschmahmann aschmahmann force-pushed the fix/7624-do-not-fetch-on-pin-ls branch from 1291d66 to 077e3e0 Compare August 26, 2020 18:36
@aschmahmann aschmahmann merged commit 38da1cc into master Aug 26, 2020
@aschmahmann aschmahmann mentioned this pull request Sep 22, 2020
72 tasks
@hacdias hacdias deleted the fix/7624-do-not-fetch-on-pin-ls branch May 9, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants