Set supported platforms by go-version #7927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set supported platforms correctly by go version (no darwin-386 for >=1.15, no darwin-arm64 unless >=1.16), make check-go-version work on mac License: MIT Signed-off-by: hannahhoward <hannah@hannahhoward.net>
Stebalien
approved these changes
Feb 25, 2021
Comment on lines
+21
to
+23
| ifeq ($(shell bin/check_go_version "1.15.0" 2>/dev/null; echo $$?),1) | ||
| SUPPORTED_PLATFORMS += darwin-386 | ||
| endif |
There was a problem hiding this comment.
I'd drop support for this entirely, but we can do that later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like darwin-386 is in the list of supported platforms still as of 0.8.0, which won't compile on go-1.15 and up. And now there's darwin-arm64 (native Apple M1) starting on Go 1.16
This PR set supported platforms correctly by go version (no darwin-386 for >=1.15, no darwin-arm64 unless >=1.16)
It also makes a change to check-version as + is interpreted literally for
expron several POSIX systems including Mac.License: MIT
Signed-off-by: hannahhoward hannah@hannahhoward.net