Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Remove Delete methods from DagService #43

Open
kevina opened this issue Sep 24, 2018 · 0 comments
Open

RFC: Remove Delete methods from DagService #43

kevina opened this issue Sep 24, 2018 · 0 comments

Comments

@kevina
Copy link
Contributor

kevina commented Sep 24, 2018

When we switch the blockstore over to use multihashes instead of Cids the Deletes from a Dagservice that is backed by a blockstore will become problematic.

From ipfs/kubo#5510:

The dagservice has a Delete method. This is problematic. For example if you insert a raw and a Protobuf version of the same Node then delete the one of those nodes via the dagservice both will be deleted. We should probably delete these methods. The only place the Delete method seams to be used is in dagutils/utils.go. I have marked two of the three instances with comments.

Does the delete methods serve a useful purpose?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant