Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helia incompatible with latest js-stores datastores #585

Closed
Tracked by #586
leblowl opened this issue Aug 30, 2024 · 3 comments
Closed
Tracked by #586

Helia incompatible with latest js-stores datastores #585

leblowl opened this issue Aug 30, 2024 · 3 comments
Assignees
Labels
dif/easy Someone with a little familiarity can pick up effort/hours Estimated to take one or several hours kind/maintenance Work required to avoid breaking changes or harm to project's status quo P0 Critical: Tackled by core team ASAP status/ready Ready to be worked

Comments

@leblowl
Copy link

leblowl commented Aug 30, 2024

Due to ipfs/js-stores#315, it appears that any code like this is currently incompatible:

if (err.code !== 'ERR_NOT_FOUND') {

For now, if you are using Helia 4.2.5 and Level (for example), it looks like datastore-level < 11.0.0 is required

@SgtPooki SgtPooki self-assigned this Aug 30, 2024
@SgtPooki SgtPooki added P0 Critical: Tackled by core team ASAP dif/easy Someone with a little familiarity can pick up effort/hours Estimated to take one or several hours kind/maintenance Work required to avoid breaking changes or harm to project's status quo status/in-progress In progress labels Aug 30, 2024
@SgtPooki
Copy link
Member

SgtPooki commented Aug 30, 2024

@leblowl FYI: libp2p2.0 is coming soon and will also be changing error codes from .code to .name so we will likely not have this change out in a new Helia release until we can bring them both in

edit to add link to libp2p2.0 issue

@SgtPooki SgtPooki mentioned this issue Aug 30, 2024
5 tasks
@SgtPooki SgtPooki added status/ready Ready to be worked and removed status/in-progress In progress labels Aug 30, 2024
@achingbrain
Copy link
Member

achingbrain commented Sep 13, 2024

The .code property was re-added to the js-stores implementations by ipfs/js-stores#320 so this issue should be fixed now. Sorry for the disruption.

The next Helia major will switch to using the .name property anyway but things are backwards compatible now.

@achingbrain
Copy link
Member

I'm going to close this issue, please re-open it if you're still having problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dif/easy Someone with a little familiarity can pick up effort/hours Estimated to take one or several hours kind/maintenance Work required to avoid breaking changes or harm to project's status quo P0 Critical: Tackled by core team ASAP status/ready Ready to be worked
Projects
None yet
Development

No branches or pull requests

3 participants