Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MV3 Beta Bug] The first page load is missing content, refresh is good #1202

Closed
Tracked by #1152
whizzzkid opened this issue May 19, 2023 · 1 comment
Closed
Tracked by #1152

[MV3 Beta Bug] The first page load is missing content, refresh is good #1202

whizzzkid opened this issue May 19, 2023 · 1 comment
Assignees
@whizzzkid
Labels
area/MV3 Issues related to Manifest V3 version kind/bug A bug in existing code (including security flaws) mv3-beta-bugs

Comments

@whizzzkid
Copy link
Contributor

The first page load seems to load a few assets fine and not everything. This most likely happens because the way we discover if a request is serviceable by resolving ipns. Since this happens async and the rule gets added dynamically after, which causes a few requests to fail.

The refresh works because the redirection rule now exists and resolves everything

image
@whizzzkid whizzzkid added kind/bug A bug in existing code (including security flaws) area/MV3 Issues related to Manifest V3 version mv3-beta-bugs labels May 19, 2023
@whizzzkid whizzzkid self-assigned this May 19, 2023
@whizzzkid whizzzkid mentioned this issue May 19, 2023
Open
@whizzzkid
Copy link
Contributor Author

On Brave: clicking on the (ipns) icon in the address bar triggers the Brave flow, this should not happen.

@whizzzkid whizzzkid mentioned this issue May 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whizzzkid whizzzkid

Labels
area/MV3 Issues related to Manifest V3 version kind/bug A bug in existing code (including security flaws) mv3-beta-bugs
Projects
No open projects
IPFS-GUI (PL EngRes)
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@whizzzkid