Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

window.ipfs ACL should match the http read-only / gateway API #597

Closed
olizilla opened this issue Sep 27, 2018 · 2 comments
Closed

window.ipfs ACL should match the http read-only / gateway API #597

olizilla opened this issue Sep 27, 2018 · 2 comments
Labels
area/window-ipfs Issues related to IPFS API exposed on every page kind/discussion Topical discussion; usually not changes to codebase status/deferred Conscious decision to pause or backlog

Comments

@olizilla
Copy link
Member

go-ipfs exposes a subset of the API to the gateway as a public / read-only version of the regular API. The white list we use for window.ipfs should be derived from that list, if it isn't already.

Current definition of the read-only api https://github.com/ipfs/go-ipfs/blob/727bf49eff7ff61936aee6d4674ae3e7ad0aaddb/core/commands/root.go#L155-L187

@lidel lidel added area/window-ipfs Issues related to IPFS API exposed on every page kind/discussion Topical discussion; usually not changes to codebase labels Sep 27, 2018
@lidel
Copy link
Member

lidel commented Sep 27, 2018

I like the idea of having the source of truth for this somewhere else, "Public API exposed on Gateway port" feels like a good match.

That being said, right now, the lack of add on the list makes this proposal bit problematic.
If dapps are unable to add data over window.ipfs, why would anyone use it?
Is there an upstream issue for go-ipfs about changing defaults or making this list configurable?

@lidel lidel added the status/deferred Conscious decision to pause or backlog label Sep 27, 2018
@lidel
Copy link
Member

lidel commented Oct 19, 2020

Closing due to #589 (comment)

@lidel lidel closed this as completed Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/window-ipfs Issues related to IPFS API exposed on every page kind/discussion Topical discussion; usually not changes to codebase status/deferred Conscious decision to pause or backlog
Projects
None yet
Development

No branches or pull requests

2 participants