Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run JS interface tests (js-kubo-rpc-client) on CI #8450

Open
lidel opened this issue Sep 20, 2021 · 3 comments
Open

Run JS interface tests (js-kubo-rpc-client) on CI #8450

lidel opened this issue Sep 20, 2021 · 3 comments
Assignees
Labels
kind/maintenance Work required to avoid breaking changes or harm to project's status quo kind/test Testing work topic/rpc-api Issues related to Kubo RPC API at /api/v0
Milestone

Comments

@lidel
Copy link
Member

lidel commented Sep 20, 2021

Right now, js-ipfs runs tests that ensure js-ipfs-http-client works against the last go-ipfs release.
This has a downside of being a late feedback loop – if go-ipfs breaks something in the HTTP client for JS, we learn about it too late.

We should run js-ipfs interface tests in go-ipfs CI to get early feedback and have time to fix any regressions.

Implementation details

@lidel lidel added topic/rpc-api Issues related to Kubo RPC API at /api/v0 kind/maintenance Work required to avoid breaking changes or harm to project's status quo labels Sep 20, 2021
@lidel lidel self-assigned this Sep 20, 2021
@lidel lidel added the kind/test Testing work label Sep 20, 2021
@BigLep BigLep added this to the TBD milestone Mar 10, 2022
@tinytb tinytb changed the title Run JS interface tests (js-ipfs-http-client) on CI Run JS interface tests (js-kubo-rpc-client) on CI Jan 3, 2023
@tinytb
Copy link

tinytb commented Jan 3, 2023

Updated title to reflect the (new) http client that we need tested in kubo CI. https://github.com/ipfs/js-kubo-rpc-client

Can the kubo team take this on?

@SgtPooki
Copy link
Member

SgtPooki commented Jan 3, 2023

related: ipfs/js-kubo-rpc-client#77

@SgtPooki
Copy link
Member

SgtPooki commented Jan 3, 2023

I can look into this if this is something we want to prioritize @lidel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/maintenance Work required to avoid breaking changes or harm to project's status quo kind/test Testing work topic/rpc-api Issues related to Kubo RPC API at /api/v0
Projects
No open projects
Status: Backlog
Status: 🥞 Todo
Development

No branches or pull requests

4 participants