Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to go-log v2 #8753

Open
3 tasks done
aschmahmann opened this issue Mar 1, 2022 · 4 comments · May be fixed by #8765
Open
3 tasks done

Switch to go-log v2 #8753

aschmahmann opened this issue Mar 1, 2022 · 4 comments · May be fixed by #8765
Labels
kind/enhancement A net-new feature or improvement to an existing feature

Comments

@aschmahmann
Copy link
Contributor

aschmahmann commented Mar 1, 2022

Checklist

  • My issue is specific & actionable.
  • I am not suggesting a protocol enhancement.
  • I have searched on the issue tracker for my issue.

Description

https://github.com/ipfs/go-log v2 has been out for quite a while now and go-libp2p v0.18.0 (the biggest source of go-log v1 outputs) is switching over to v2. We should too so that it can finally be deprecated.

This will also lead to the output of ipfs log tail becoming effectively useless which is largely happening anyway as a result of other components (e.g. go-libp2p) dropping support for go-log v1. This gives us an opportunity to make ipfs log tail more useful. For example, mirroring the daemon log output via ipfs log tail so it can be fetched over the HTTP API and doesn't have to track all log outputs just those from while the command is running.

cc @lidel @guseggert

@aschmahmann aschmahmann added the kind/enhancement A net-new feature or improvement to an existing feature label Mar 1, 2022
@lidel
Copy link
Member

lidel commented Mar 1, 2022

:+1 for making /api/v0/log/tail useful over HTTP

My wishlist is short:

  • ability to log/tail by level (DEBUG/INFO/WARN/ERROR)
  • ability to log/tail by subsystem (

It will enable us to add log explorer with filtering per system in ipfs-webui / ipfs-desktop (cc @SgtPooki)

@BigLep
Copy link
Contributor

BigLep commented Mar 1, 2022

@aschmahmann : is this a good candidate for @schomatis ?

@schomatis
Copy link
Contributor

Sounds like it. Will go ahead with this one unless explicitly flagged otherwise.

@schomatis schomatis self-assigned this Mar 2, 2022
@aschmahmann
Copy link
Contributor Author

Yep seems reasonable. We should probably use the go-log format (https://github.com/ipfs/go-log#golog_log_level) for describing particular subsystems to get logs for though.

@BigLep BigLep added this to the Best Effort Track milestone Mar 3, 2022
@schomatis schomatis linked a pull request Mar 4, 2022 that will close this issue
@BigLep BigLep assigned Jorropo and unassigned schomatis Sep 1, 2022
@Jorropo Jorropo removed their assignment Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A net-new feature or improvement to an existing feature
Projects
No open projects
Status: 🥞 Todo
Development

Successfully merging a pull request may close this issue.

5 participants