Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circle CI not flipping green on some PR #9084

Closed
Jorropo opened this issue Jul 5, 2022 · 6 comments
Closed

Circle CI not flipping green on some PR #9084

Jorropo opened this issue Jul 5, 2022 · 6 comments
Assignees
Labels
kind/bug A bug in existing code (including security flaws) need/analysis Needs further analysis before proceeding need/triage Needs initial labeling and prioritization team/ipdx Notify IP Developer Experience team topic/ci Continuous integration

Comments

@Jorropo
Copy link
Contributor

Jorropo commented Jul 5, 2022

It seems that when the PR is comming from:

  • An organization.
  • An account of someone who have circle CI configured.

The CI is not correctly reporting status. Example: #9069

This is a long bug we notice often. It's painfull and we should fix it.

@Jorropo Jorropo added kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization need/analysis Needs further analysis before proceeding topic/ci Continuous integration labels Jul 5, 2022
@galargh galargh added the team/ipdx Notify IP Developer Experience team label Sep 12, 2022
@galargh galargh self-assigned this Sep 12, 2022
@galargh
Copy link
Contributor

galargh commented Sep 13, 2022

According to CircleCI's blog (https://support.circleci.com/hc/en-us/articles/360008097173-Troubleshooting-why-pull-requests-are-not-triggering-jobs-on-my-organization-) it can happen when:

  1. ❎ you revoked OAuth access to CircleCI on your VCS provider (GitHub, BitBucket)
  2. ❓ you're following the fork instead of the upstream repo
  3. ❎ the branch and the pull request happen to be created simultaneously

1 is definitely not the case because we wouldn't be getting any builds if that was the case.

3 is not it either because we don't have Only build pull requests turned on in CircleCI for kubo.

2 is possible but @2color said he didn't have runs in his account - #9069 (comment). @2color could you check if you have go-ipfs project set up in https://app.circleci.com/projects/project-dashboard/github/2color/? And if so, if you're following it? My theory is that it would be enough to block the original repo from running workflows, even if you don't have it configured to actually perform the runs.

Other possibility would be that GitHub lost some webhooks but given that there was quite a bit of activity on the PR this seems quite unlikely.

@Jorropo if you notice it again on some other PR, could you let me know? I'd like to investigate webhook logs.

@2color
Copy link
Member

2color commented Sep 13, 2022

I hadn't set up CircleCI for the project. This is what I have:

Screen Shot 2022-09-13 at 2 17 00 PM

@galargh
Copy link
Contributor

galargh commented Sep 13, 2022

Thanks for checking!

Btw, I also test opened two PRs, one from my priv account - #9268 - and the other from my test org - #9269 - and they both triggered runs as expected...

@Jorropo
Copy link
Contributor Author

Jorropo commented Sep 13, 2022

@galargh AFAIK it is reliably failing with some peoples, @2color could you please a new test pull request ?

@galargh
Copy link
Contributor

galargh commented Oct 20, 2022

Quick update: we're not addressing this issue in the hope we can deliver #8804 instead which would mean we're completely off of CircleCI.

@BigLep
Copy link
Contributor

BigLep commented Nov 11, 2022

Closing as not planned given #8804

@BigLep BigLep closed this as not planned Won't fix, can't repro, duplicate, stale Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws) need/analysis Needs further analysis before proceeding need/triage Needs initial labeling and prioritization team/ipdx Notify IP Developer Experience team topic/ci Continuous integration
Projects
None yet
Development

No branches or pull requests

4 participants