Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional Pubsub.SeenMessagesTTL to Kubo config #9371

Closed
3 tasks done
smrz2001 opened this issue Oct 26, 2022 · 1 comment · Fixed by #9372
Closed
3 tasks done

Add optional Pubsub.SeenMessagesTTL to Kubo config #9371

smrz2001 opened this issue Oct 26, 2022 · 1 comment · Fixed by #9372
Labels
help wanted Seeking public contribution on this issue kind/feature A new feature P2 Medium: Good to have, but can wait until someone steps up

Comments

@smrz2001
Copy link
Contributor

smrz2001 commented Oct 26, 2022

Checklist

  • My issue is specific & actionable.
  • I am not suggesting a protocol enhancement.
  • I have searched on the issue tracker for my issue.

Description

As discussed in this Slack thread, this is a feature request to make Pubsub.SeenMessagesTTL configurable in Kubo's Pubsub config:

Support for this option is now available in go-libp2p-pubsub v0.7.0 onwards.

As explained in that thread, we would very much like to be able to use this option to adjust the duration for which pubsub messages can remain active on the network.

@smrz2001 smrz2001 added the kind/feature A new feature label Oct 26, 2022
@ipfs ipfs deleted a comment from welcome bot Oct 26, 2022
@lidel lidel added help wanted Seeking public contribution on this issue P2 Medium: Good to have, but can wait until someone steps up labels Oct 26, 2022
@lidel
Copy link
Member

lidel commented Oct 26, 2022

Exposing this as optionalDuration in the config sounds sensible.

If someone wants this feature and is willing to submit a PR, we are happy to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Seeking public contribution on this issue kind/feature A new feature P2 Medium: Good to have, but can wait until someone steps up
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants