Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubo v0.22.0 feedback #17

Closed
galargh opened this issue Jul 27, 2023 · 11 comments
Closed

Kubo v0.22.0 feedback #17

galargh opened this issue Jul 27, 2023 · 11 comments
Assignees
Labels
P3 Low: Not priority right now

Comments

@galargh
Copy link
Contributor

galargh commented Jul 27, 2023

Improvements related to ipfs/kubo#9911

@galargh
Copy link
Contributor Author

galargh commented Jul 27, 2023

https://filecoinproject.slack.com/archives/C04M8232QRW/p1690456755274109?thread_ts=1690375900.878299&cid=C04M8232QRW

Ok thx, I just did go install github.com/ipfs/kuboreleaser/cmd/kuboreleaser@latest would be nice if I could do kuboreleaser env instead

@Jorropo
Copy link
Collaborator

Jorropo commented Jul 27, 2023

I don't like that GPG ask for me a passphrase:

Please provide a GPG passphrase for the key E73D5CF05FC2A3CD0A62C557C5B8248338D8A171.
GPG passphrase:

I guess it's gonna save it somewhere which kinda defeats the point of a passphrase.
After reading the source it loads the key, the text could be mentioned to explain how this key is used.

It does save it to .env.

Or better when I use git -S a GTK prompt automagically open to ask me for my passphrase when required, would be nice to do the same thing, also this has a "sudo mode" if I enter the password once with a session it does not reask me again in the short while.

@Jorropo
Copy link
Collaborator

Jorropo commented Jul 27, 2023

Would be nice if the chore: update version commit was signed, (idk how it's gonna make the tag, if the tag is signed by me then this is not important).

@Jorropo
Copy link
Collaborator

Jorropo commented Jul 27, 2023

Your release PR is ready at https://github.com/ipfs/kubo/pull/10034\nIf needed, check out the release-v0.22.0 branch of ipfs/kubo repository and cherry-pick commits from master using the following command:

Is someone trying to use \n in an ` string literal ?

@Jorropo
Copy link
Collaborator

Jorropo commented Jul 27, 2023

I would like to have a publish-to-all step that merge all the publish steps (ideally concurrently but fine if not).

@galargh
Copy link
Contributor Author

galargh commented Aug 16, 2023

ipfs/kubo#9911 (comment)

@BigLep
Copy link

BigLep commented Jan 3, 2024

@Jorropo @hacdias : is there anything open here to still to handle or can we resolve?

@hacdias
Copy link
Member

hacdias commented Jan 4, 2024

I don't think any of this has been handled yet

@galargh
Copy link
Contributor Author

galargh commented Jan 4, 2024

Here's a quick summary:

  • Prompt for GPG pass instead of saving it to .env - addressed in feat: make env optional, prompt when not set #23
  • Sign chore: update version commit - decided not to address it since the subsequent tag is signed by whomever drives the release
  • \n rendering - addressed in feat: make env optional, prompt when not set #23
  • add publish-to-all command (it should run all the other publish commands)
  • make sure marking releases as latest in ipfs/kubo works as expected (tldr, now, if we release a patch for the previous major/minor version, it will be marked as latest even though it should not)
  • add env command (it should do what make env does; it will allow installing kuboreleaser through go install without cloning the repo)

@hacdias
Copy link
Member

hacdias commented Jan 4, 2024

(I guess I have to update my clone 😆 )

@hacdias
Copy link
Member

hacdias commented Jan 25, 2024

I extracted the next steps to #30 , #31 and #32.

@hacdias hacdias closed this as completed Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Low: Not priority right now
Projects
No open projects
Archived in project
Development

No branches or pull requests

4 participants