Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ignite-metrics - Add telemetry without UI #106

Closed
Tracked by #105 ...
SgtPooki opened this issue Jan 18, 2023 · 0 comments · Fixed by #108
Closed
Tracked by #105 ...

feat: ignite-metrics - Add telemetry without UI #106

SgtPooki opened this issue Jan 18, 2023 · 0 comments · Fixed by #108

Comments

@SgtPooki
Copy link
Contributor

SgtPooki commented Jan 18, 2023

Add telemetry according to ipfs/ipfs-gui#105.

See ipfs/ipfs-gui#105 (comment) for more
details about why there is no UI treatment.

Users will be able to opt out by executing the function removeMetricsConsent in their browser console: removeMetricsConsent(). They can re-add consent using addMetricsConsent().

Gotchas for this repo

This page is bundled up into webui, so we need to make sure we use metrics from webui if it’s being loaded there

App Location Emit Metrics?
explore.ipld.io website true
webui only if we propagate through webui (needs further work)
ipfs-desktop only if we propagate through ipfs-desktop (needs further work)

So in the webui and desktop cases, we should just not emit any metrics from explore.ipld.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant