From 02b9c8dc1b242326ec17ea694b561bba5b5fb96a Mon Sep 17 00:00:00 2001 From: hannahhoward Date: Thu, 7 Nov 2019 14:31:02 -0800 Subject: [PATCH] fix(schema/gen): return value not reference Map/List should return an actual node type, not a pointer to a node. Otherwise, breaks when nested in other map/list type --- schema/gen/go/genKindListNode.go | 2 +- schema/gen/go/genKindStructNode.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/schema/gen/go/genKindListNode.go b/schema/gen/go/genKindListNode.go index 39a77cb5..e874915a 100644 --- a/schema/gen/go/genKindListNode.go +++ b/schema/gen/go/genKindListNode.go @@ -278,7 +278,7 @@ func (gk generateNbKindList) EmitNodebuilderMethodCreateList(w io.Writer) { } func (lb *{{ .Type | mungeTypeNodeListBuilderIdent }}) Build() (ipld.Node, error) { - v := lb.v + v := *lb.v lb = nil return v, nil } diff --git a/schema/gen/go/genKindStructNode.go b/schema/gen/go/genKindStructNode.go index 906382f7..75e875b2 100644 --- a/schema/gen/go/genKindStructNode.go +++ b/schema/gen/go/genKindStructNode.go @@ -272,7 +272,7 @@ func (gk generateNbKindStruct) EmitNodebuilderMethodCreateMap(w io.Writer) { } {{- end}} {{- end}} - v := mb.v + v := *mb.v mb = nil return v, nil }