Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add newline at EOF for ambient-sc.yaml #51767

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

kfaseela
Copy link
Member

@kfaseela kfaseela commented Jun 27, 2024

Please provide a description of this PR:

This is required to fix the failure seen in the new integ-ambient-ipv6 CI job.
#51765

Part of #51222

Signed-off-by: Faseela K <faseela.k@est.tech>
@kfaseela kfaseela requested a review from a team as a code owner June 27, 2024 13:43
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 27, 2024
@kfaseela kfaseela added release-notes-none Indicates a PR that does not require release notes. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 27, 2024
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 27, 2024
@kfaseela
Copy link
Member Author

@jwendell is the origin for this file also in a different repo? or this is good?

@kfaseela
Copy link
Member Author

/retest

@istio-testing istio-testing merged commit 5474ff6 into istio:master Jun 27, 2024
27 of 28 checks passed
@kfaseela kfaseela deleted the fix-ambient-sc-yaml-for-ipv6 branch September 12, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test and release release-notes-none Indicates a PR that does not require release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants