Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dude, fix your fucking code #36

Closed
3 tasks
jaebradley opened this issue Feb 28, 2017 · 3 comments
Closed
3 tasks

Dude, fix your fucking code #36

jaebradley opened this issue Feb 28, 2017 · 3 comments

Comments

@jaebradley
Copy link
Owner

Where to start?

  • Data objects have Uber-specific implementation details (distance in miles? time in seconds? wtf?!?) Just because Uber defines it like that does not mean your internal interface should.
  • Objects know how they're formatted? Yeah, fuck that. Formatters know how objects are formatted.
  • Tests are brittle as fuck. If they were any more brittle, they'd have fucking osteoporosis. Also, add more unit tests vs. having basically integration tests (which were fine when it was uh less public).
@mikeres0
Copy link

mikeres0 commented Mar 2, 2017

I thought this was just a user and not the repo owner, I was about to be like wtf?!

@gaulatti
Copy link

5 months after, there's any sight?

@jaebradley jaebradley mentioned this issue Jun 12, 2018
Merged
@jaebradley
Copy link
Owner Author

Hopefully most concerns have been dealt with in #66.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gaulatti @mikeres0 @jaebradley