You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The issue was brought up via email, see this thread.
IIRC, according to TCK doc, all intentionally disabled tests should be mentioned in tck-tests.xml.
However, we currently have two tests that are disabled directly in code and not mentioned in the XML, those are:
The assertion linked to this test is marked as not testable and due to the limitation on the type of resource in web.xml the original format of this test was invalid.
I don't believe we can test this - the set of valid values for resource is limited and it seems that its types are all legal bean types.
We could probably just delete this test and associated unused classes.
The assumption made by this test seems correct but there is no guarantee about when that happens.
However, if we make sure the test actually creates an instance of the bean (so that injection into contextual reference triggers), it should be safe to assert it. This is something we should check up on with OWB impl which originally filed the TCK JIRA.
The issue was brought up via email, see this thread.
IIRC, according to TCK doc, all intentionally disabled tests should be mentioned in
tck-tests.xml
.However, we currently have two tests that are disabled directly in code and not mentioned in the XML, those are:
We need to take a look at them and determine how to treat them (i.e. if they still need to be disabled and is so then do that via XML file).
The text was updated successfully, but these errors were encountered: